Log message on abortStartup due to unexpected model loading failures #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leon Kiefer <[email protected]>
Legion2
force-pushed
the
log-abort-startup
branch
from
c260ebe to
45a1af9
Compare
rafvasq
approved these changes
Jan 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner, Legion2, rafvasq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Help debugging unready condition of modelmesh in case of model loading failures.
The logged message helps to pinpoint the root cause of unready condition.
Fix #100
Modifications
Log a message in isReady check explaining the cause of NOT READY condition.
There are already logs for the other NOT READY conditions.
Result
Returning NOT READY to readiness probe due to unexpected model loading failuresis logged when there are model loading issues during startup.